Provide feedback when using deprecated %d specifiers in RUNPATH #4474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreas-el
force-pushed
the
runpath_specifier_feedback
branch
2 times, most recently
from
c6905b9 to
cdb1085
Compare
andreas-el
force-pushed
the
runpath_specifier_feedback
branch
5 times, most recently
from
2e43282 to
541d7db
Compare
andreas-el
force-pushed
the
runpath_specifier_feedback
branch
from
498a5ca to
5471f1c
Compare
andreas-el
force-pushed
the
runpath_specifier_feedback
branch
from
58be1eb to
f31883d
Compare
andreas-el
commented
Jan 2, 2023
Codecov Report
@@ Coverage Diff @@
## main #4474 +/- ##
==========================================
+ Coverage 59.65% 59.67% +0.02%
==========================================
Files 444 444
Lines 31326 31313 -13
Branches 3076 3076
==========================================
- Hits 18686 18685 -1
+ Misses 11866 11854 -12
Partials 774 774
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
andreas-el
added
the
release-notes:maintenance
andreas-el
force-pushed
the
runpath_specifier_feedback
branch
from
8252c6b to
51bcde8
Compare
andreas-el
changed the title
andreas-el
force-pushed
the
runpath_specifier_feedback
branch
4 times, most recently
from
86e5c77 to
2cb7f99
Compare
eivindjahren
reviewed
Jan 3, 2023
| elif not any(x in runpath_format_string for x in ["<ITER>, <IENS>"]): | ||
| self.runpath_format_string = runpath_format_string | ||
| logger.error( | ||
| "RUNPATH keyword shall use syntax " f"`{self.DEFAULT_RUNPATH}`." |
There was a problem hiding this comment.
Maybe should instead instead of shall ?
There was a problem hiding this comment.
Sure thing.
And added new issue for suggester ui.
#4543
eivindjahren
requested changes
Jan 3, 2023
andreas-el
force-pushed
the
runpath_specifier_feedback
branch
from
2cb7f99 to
acb6346
Compare
eivindjahren
approved these changes
Jan 3, 2023
Remove iteration_count property Remove obsoleted test Add LibresFacade testing valid runpaths Added logger feedback on deprecated syntax for runpath Update documentation for RUNPATH Replace jobname specifiers with <ITER> and <IENS>
Before load results manually would check whether runpath was valid, however that just checked for the precense of %d. Since results can be loaded regardless of %d, this button is now always enabled.
andreas-el
force-pushed
the
runpath_specifier_feedback
branch
from
acb6346 to
e2dd788
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #4432
Resolves #4443
Updated docs
Updated deprecated syntax for RUNPATH in ert-files, tests and examples
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.